Remove DNS TXT Match fron OneTrust CMP #2
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DSN TXT Match seems to be buggy in Wappalyzer and matches domains such as www.google.com flaggying it to be using OneTrust or other technologies not being used like "Apple iCloud Mail"
Member
|
As discussed offline, someone has verified OneTrust against google.com as can see it in DNS: As it's not used on ALL google.com properties, I agree it's not a great check to reply on that DNS entry, and the other ones are probably better checks so agree with removing this. This is however our first divergence from Wappalyzer since they closed-sourced this. Are we happy to diverge? There was some talk of others maintaining an open-source version but not sure if that will happen (or if they realise how much work this will be!) |
rviscomi
approved these changes
Sep 26, 2023
Member
rviscomi
left a comment
rviscomi
left a comment
There was a problem hiding this comment.
I'm ok to diverge for the time being. If and when we settle on a better solution we can merge any changes upstream.
tunetheweb
approved these changes
Sep 27, 2023
Contributor
Author
|
@rviscomi friendly ping, can we remove this dns match on OneTrust to exclude these outliers? Thanks |
max-ostapenko
added a commit
that referenced
this pull request
Apr 25, 2025
* lint * cleanup * npm * test error * test error #2 * remove errors * reset schema changes * standard and puppeteer * editorconfig * updated eslint config
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
OneTrust CMP Detection is buggy, currently it matches www.google.com as being used OneTrust where it's not the case.
https://www.webpagetest.org/jsonResult.php?test=230926_AiDcK7_97Z&highlight=1
I would suggest to remove this match for OneTrust to solve this issue.
@rviscomi @pmeenan FYI